Fix SKPaint.Clone

[jeremy-visionaid]

Clone should operate on SkCompatPaint

Description of Change

Fix crash on dispose of a cloned SKPaint

Bugs Fixed

• Fixes [BUG] (preview3.1) Access violation when a Cloned SKPaint is disposed/finalized #2899

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

• Has tests (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Merged related skia PRs
• Changes adhere to coding standard
• Updated documentation

[chersoft-oliverb]

Hi @mattleibow could you cast an 👀 over this please?

We'd like to prep our codebase for 3.0 but this issue is a blocker at the moment.

Thanks!

[mattleibow]

This is exactly what should have been done.

The clone is not a normal function like the rest, it just instantiates a copy:

sk_paint_t* sk_paint_clone(sk_paint_t* paint) {
    return ToPaint(new SkPaint(*AsPaint(paint)));
}

Thanks!