This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
[reflection] Changes in Type.cs, TypeTests.cs and TypeTests.netcoreapp.cs #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from referencesource; disable some test cases in TypeTests.cs and TypeTests.netcoreapp.cs
akoeplinger
approved these changes
Nov 15, 2018
| @@ -23,7 +23,11 @@ public abstract partial class Type : MemberInfo, IReflect | |||
| public abstract string FullName { get; } | |||
|
|
|||
| public abstract Assembly Assembly { get; } | |||
| #if MONO | |||
| public override abstract Module Module { get; } | |||
There was a problem hiding this comment.
Keep the comment from the refsrc code:
Suggested change
| public override abstract Module Module { get; } | |
| // Workaround for JIT bug with bad VTable lookup | |
| // | |
| // MemberInfo mi = typeof (System.DBNull); | |
| // System.Console.WriteLine (mi.Module); | |
| // | |
| public override abstract Module Module { get; } |
I assume you checked if this bug still exists?
There was a problem hiding this comment.
I don't have any failures related to removing this workaround. I left it only due to potential API change. If that API change is OK then I can revert it.
There was a problem hiding this comment.
It should be fine to remove the workaround.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to mono/mono#11665.
The changes:
MonoTests.System.Reflection.Emit.TypeBuilderTest.TestIsContextful;changed Module property fromnewtooverrideto avoid API change.