This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
[System.Native] Exclude ReadDir pinvoke wrappers on Mono; handle EINTR #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
akoeplinger,
marek-safar and
steveisok
and removed request for
marek-safar
For Mono we must loop in managed when opendir/readdir/closedir return EINTR in order to handle Thread.Abort. This is because while a thread abort will break syscalls with EINTR, throwing the ThreadAbortException will only happen when the pinvoke returns. (Although opendir/readdir/clsoedir are not documented to return EINTR, they do so on macOS Big Sur under certain conditions, so we will need to add managed looping) Related to mono/mono#20799
lambdageek
force-pushed
the
readdir-errno
branch
from
8e49997
to
e86f4b3
Compare
marek-safar
approved these changes
Apr 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Mono we must loop in managed when opendir/readdir/closedir return EINTR in
order to handle Thread.Abort.
This is because while a thread abort will break syscalls with EINTR, throwing the
ThreadAbortException will only happen when the pinvoke returns.
(Although opendir/readdir/clsoedir are not documented to return EINTR, they do
so on macOS Big Sur under certain conditions, so we will need to add managed looping)
Related to mono/mono#20799
This is needed by mono/mono#21016