This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Fix System.Native compilation on Linux #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For mono/mono#8051 |
luhenry
changed the title
luhenry
force-pushed
the
corefx-System.Native
branch
from
433b2d5
to
2a6e39d
Compare
ghost
reviewed
May 1, 2018
| #ifdef static_assert | ||
| #define c_static_assert(e) static_assert((e),"") | ||
| #elif defined(__has_extension) && __has_extension(c_static_assert) | ||
| #elif __has_extension(c_static_assert) |
There was a problem hiding this comment.
Is it change needed if we have #define __has_extension() above? We can probably define these in makefile to keep the the files closer to the source.
There was a problem hiding this comment.
It's much simpler to keep the check in this header rather than spread it around in a Makefile. Especially since https://github.com/mono/corefx/pull/46/files#diff-a4c8175f5b95c7ffaebf40eccc196d7fR16 will be a no-op if it's already defined. Also, this change will be upstreamed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.