[sre] Handle null values in MarshalAsAttribute CustomAttributeBuilder #12872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally strings are encoded as length-then-utf8 in ECMA-335. But a null String is encoded as just the byte 0xFF. When we make a CustomAttributeBuilder for a MarshalAsAttribute and attach it to some parameter we first encode the CAB as a byte blob and then decode it in CAB.get_umarshal into a UnmanagedMarshal attribute. But the decoding didn't account for the possibility of null strings. Fixes mono#12747
lambdageek
requested review from
akoeplinger,
marek-safar and
vargaz
as code owners
vargaz
approved these changes
Feb 7, 2019
|
@monojenkins backport to 2019-02 |
|
@monojenkins backport to 2018-12 |
|
@monojenkins backport to 2018-10 |
This was referenced Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally strings are encoded as length-then-utf8 in ECMA-335. But a null
String is encoded as just the byte 0xFF.
When we make a CustomAttributeBuilder for a MarshalAsAttribute and attach it to
some parameter we first encode the CAB as a byte blob and then decode it in
CAB.get_umarshal into a UnmanagedMarshal attribute. But the decoding didn't
account for the possibility of null strings.
Fixes #12747