[mono][metadata] Add a method custom attribute scanning function #19880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our normal custom attribute lookup method may trigger loading. This is undesirable during class initialization, for example. For this reason, we have `mono_class_metadata_foreach_custom_attr` that scans a class for custom attributes without triggering loading. This PR adds `mono_method_metadata_foreach_custom_attr` that does the same thing - looks for custom attributes on methods without causing any loader activity. This PR also reorganizes the code in `class-init.c` that uses these metadata custom attribute lookups to be a bit easier to use. Finally we add a convenience method (unused so far) to look for `PreserveBaseOverridesAttribute` which is defined in dotnet/runtime#35315 and which will be necessary to implement covariant returns.
monojenkins
force-pushed
the
sync-pr-37172-from-runtime
branch
from
08103d3
to
e78e0ce
Compare
lambdageek
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#37172, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Our normal custom attribute lookup method may trigger loading. This is undesirable during class initialization, for example. For this reason, we have
mono_class_metadata_foreach_custom_attrthat scans a class for custom attributes without triggering loading.This PR adds
mono_method_metadata_foreach_custom_attrthat does the same thing - looks for custom attributes on methods without causing any loader activity.This PR also reorganizes the code in
class-init.cthat uses these metadata custom attribute lookups to be a bit easier to use.Finally we add a convenience method (unused so far) to look for
PreserveBaseOverridesAttributewhich is defined in dotnet/runtime#35315 and which will be necessary to implement covariant returns.