Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.OverflowException in IFDReader.CreateIDFEntry #36

Closed
codingdave opened this issue Sep 1, 2016 · 2 comments
Closed

System.OverflowException in IFDReader.CreateIDFEntry #36

codingdave opened this issue Sep 1, 2016 · 2 comments

Comments

@codingdave
Copy link
Contributor

For a range of pictures taken with the same camera taglib-sharp was failing with an OverflowException.
This is one example image: img
This is the exception I get when using f-spot to import that image:
overflowexception

@codingdave
Copy link
Contributor Author

I have created a pull request that fixes this issue. #37

@codingdave
Copy link
Contributor Author

codingdave commented Sep 1, 2016

Im not sure what the intention of the code is due to the lack of comments. I feel like there is a better way to fix this, e.g. checking if the size of the ByteVector is larger than the types maximal value and depending on that changing the type... or calling a new function ByteVector.ToSShort() or something else... The code at least fixes importing 82 images on my side into f-spot.

decriptor added a commit that referenced this issue Sep 5, 2016
Fix for OverflowException (Issue System.OverflowException in IFDReader.CreateIDFEntry #36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant