This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
[Xwt] Always call the base methods so widgets are sized correctly #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do not call base.SetBackendSize then the widget is not added to the queue of widgets which need resizing. As such, Window.AdjustSize will never be invoked and top level dialogs will end up completely ignoring the initial size that is set for them. By invoking the base methods unconditionally, we get the correct/desired behaviour. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=9203
|
This commit breaks the layout for the dialog when run under MD, as such we should not merge this exactly as is |
|
Might this also fix issue #120 ? |
|
Yes and #143 |
|
I committed an alternative fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not call base.SetBackendSize then the widget is not added to
the queue of widgets which need resizing. As such, Window.AdjustSize
will never be invoked and top level dialogs will end up completely
ignoring the initial size that is set for them. By invoking the base
methods unconditionally, we get the correct/desired behaviour.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=9203