Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLS should expire based on some condition #6

Closed
monokles opened this issue Jul 24, 2016 · 2 comments
Closed

URLS should expire based on some condition #6

monokles opened this issue Jul 24, 2016 · 2 comments

Comments

@monokles
Copy link
Owner

In order to make sure the shortcode pool is not exhausted, shortcodes should expire. I'm not sure what the best option would be for the expiration condition.
Here are some I've come up with so far

  • after some time period (e.g. 24 hours)
  • after the shortcoded URL has not been accessed for X amount of time
  • wipe all shortcodes every X hours

I want it to be possible for some shortcodes to be permanent when a special key is passed as a POST parameter.
@monokles
Copy link
Owner Author

This is now partially implemented.
It is possible to define policies by implementing the ExpirationPolicy interface.
However:

  • Currently there is no function to update entries yet, so updateExpirationDateTime does not do anything yet.
  • Policies are not enforced yet

@monokles
Copy link
Owner Author

implemented

@notkmhn notkmhn mentioned this issue Jul 30, 2016
Closed
notkmhn added a commit that referenced this issue Jul 30, 2016
@notkmhn
Modified expiration policy interface to also accept entry on initExpi…
a59cb7e 
…rationDateTime.

Changed shoxyserver to use the new policy interface.
Partially implements #6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monokles