Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nikic/php-parser v5 to be used once we move to php80 as requirement #88

Open
stronk7 opened this issue Jan 11, 2024 · 0 comments
Open

Comments

@stronk7
Copy link
Member

stronk7 commented Jan 11, 2024

It seems that both phpunit and php-code-coverage have
started to accept nikic/php-parser v5, but that's leading
to problems with PHP 7.4 runs, that we still support.

So, with this commit, we locked nikic/php-parser v4: 6eb7253 in January 2024.

Once we officially make moodle-cs to only support php >= 8.0
we can remove this lock (basically, remove the commit above).

This issue will be in charge of that.

stronk7 added a commit to stronk7/moodle-cs that referenced this issue Jan 11, 2024
It seems that both phpunit and php-code-coverage have
started to accept nikic/php-parser v5, but that's leading
to problems with PHP 7.4 runs, that we still support.

So, with this commit, we are locking nikic/php-parser v4

Once we officially make moodle-cs to only support php >= 8.0
we can remove this lock. Issue: moodlehq#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant