Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sniffs for file docblock @copyright and @license #125

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Mar 19, 2024

andrewnicols added a commit to andrewnicols/moodle-local_moodlecheck that referenced this pull request Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (979a494) to head (f136673).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #125      +/-   ##
============================================
+ Coverage     97.63%   97.69%   +0.06%     
- Complexity      761      778      +17     
============================================
  Files            33       34       +1     
  Lines          2240     2302      +62     
============================================
+ Hits           2187     2249      +62     
  Misses           53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, just a couple of comments, with the one about how to handle the license text being the only one really important (or it will smash us later both with CiBoT and moodle-plugin-ci.

moodle/Sniffs/Commenting/FileHasSniff.php Outdated Show resolved Hide resolved
moodle/Sniffs/Commenting/FileHasSniff.php Outdated Show resolved Hide resolved
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 super tiny detail about the configurable property only!

moodle/Sniffs/Commenting/FileExpectedTagsSniff.php Outdated Show resolved Hide resolved
@andrewnicols
Copy link
Contributor Author

Updated with latest changes (again) :)

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@stronk7 stronk7 merged commit 7c207d5 into moodlehq:main Mar 19, 2024
8 checks passed
stronk7 added a commit to moodlehq/moodle-local_moodlecheck that referenced this pull request Mar 19, 2024
Replaced by moodlehq/moodle-cs#125

Co-authored-by: Eloy Lafuente <stronk7@moodle.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants