-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sniffs for file docblock @copyright and @license #125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
============================================
+ Coverage 97.63% 97.69% +0.06%
- Complexity 761 778 +17
============================================
Files 33 34 +1
Lines 2240 2302 +62
============================================
+ Hits 2187 2249 +62
Misses 53 53 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, just a couple of comments, with the one about how to handle the license text being the only one really important (or it will smash us later both with CiBoT and moodle-plugin-ci.
a3c9106
to
2eabc49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 super tiny detail about the configurable property only!
2eabc49
to
f136673
Compare
Updated with latest changes (again) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Replaced by moodlehq/moodle-cs#125 Co-authored-by: Eloy Lafuente <stronk7@moodle.org>
Replaces moodlehq/moodle-local_moodlecheck#139