-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Subsquid Tutorial for Local ERC-20 Indexing on Local Dev Node #793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably has a lot of the same feedback as I left on the Tanssi Subsquid PR, so can you please update this PR with that feedback?
Generally speaking, make sure that:
- Code snippets are formatted correctly
- Titles make sense and are consistent
- Check grammar
- Fix target=_blank
- Terminal screenshots use the themed terminal
Please read through it and make sure it all flows! 🙌
.snippets/code/tutorials/integrations/local-subsquid/hardhat-config.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Shaben <eshaben@icloud.com>
…onfig.js Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the terminal screenshots just need to be updated to use the standard moonbeam terminal theme, but other than that it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (terminal screenshots to be taken care of at a later time)
Description
Revamps Subsquid tutorial for ArrowSquid etc.
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiracompress-images.py
script to compress the images. (Done in follow-up PR restore local squid images for chinese site #801)After Translation Requirements
moonbeam-docs
repo to remove imagesItems to be Updated
Made follow-up changes in this PR: #801
Will need to remove the old subsquid images and replace them with the ones in the
new
directory