Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Subsquid Tutorial for Local ERC-20 Indexing on Local Dev Node #793

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Nov 17, 2023

Description

Revamps Subsquid tutorial for ArrowSquid etc.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images. (Done in follow-up PR restore local squid images for chinese site #801)
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images

Items to be Updated

Made follow-up changes in this PR: #801
Will need to remove the old subsquid images and replace them with the ones in the new directory

@themacexpert themacexpert added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Nov 17, 2023
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably has a lot of the same feedback as I left on the Tanssi Subsquid PR, so can you please update this PR with that feedback?

Generally speaking, make sure that:

  • Code snippets are formatted correctly
  • Titles make sense and are consistent
  • Check grammar
  • Fix target=_blank
  • Terminal screenshots use the themed terminal

Please read through it and make sure it all flows! 🙌

tutorials/integrations/local-subsquid.md Outdated Show resolved Hide resolved
tutorials/integrations/local-subsquid.md Outdated Show resolved Hide resolved
tutorials/integrations/local-subsquid.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the terminal screenshots just need to be updated to use the standard moonbeam terminal theme, but other than that it looks good!

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (terminal screenshots to be taken care of at a later time)

@eshaben eshaben merged commit 27718b0 into master Nov 29, 2023
1 check passed
wuzhong-papermoon added a commit to moonbeam-foundation/moonbeam-docs-cn that referenced this pull request Feb 15, 2024
@eshaben eshaben deleted the themacexpert/subsquid branch August 16, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants