Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend block_timestamp implementation return seconds #40

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Oct 1, 2020

The pallet-evm implementation of evm::Backend uses pallet-timestamp to return block.timestamp value in milliseconds as opposed to the expected value in seconds.

@tgmichel tgmichel merged commit dd2bfd1 into master Oct 1, 2020
@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Oct 6, 2020

So this PR just pins changes the Substrate dependency, right? So are we using a modified version of Substrate? If so is it just for this timestamp unit conversion?

@tgmichel
Copy link
Contributor Author

tgmichel commented Oct 6, 2020

Correct, we are using pallet-evm from our substrate fork - tgmichel-rococo-branch branch. That allow us to do tailored stuff with the pallet, like logging, fixing a bug quickly or modifying it - i.e. the timestamp conversion - without waiting on a main repo PR. But for the most part is the same.

@JoshOrndorff
Copy link
Contributor

Okay , I see. It is just pallet-evm coming from our own fork. The rest of substrate comes from the official Substrate repo. 👍

@tgmichel tgmichel deleted the tgmichel-evm-timestamp branch July 6, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants