-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize collections #324
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 84.55% 83.83% -0.72%
==========================================
Files 73 74 +1
Lines 2874 2845 -29
==========================================
- Hits 2430 2385 -45
- Misses 444 460 +16 ☔ View full report in Codecov by Sentry. |
The orgnanization layout is mostly settled, thanks for your contributions |
This PR reorganizes containers into a new
collections
folder. There are two motivations:collections
folder, it becomes more convenient to share implementation between containers. For example,hashmap
andhashset
share the same underlying implementation. I split it out to be a separate package (robinhood_hash
) and they both become wrappers over it.What I did:
collections
. Moved relevant packages into it.robinhood_hash
package undercollections
. Rewritehashset
andhashmap
to be just wrappers.Unresolved issue:
core/collections/robinhood_hash
is a package visible from the outside world. No idea how to make it local tocollections
.Note:
vec
andlist
outside ofcollections
, since they are more commonly used.