-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @hash
package with SHA1 implementation
#330
base: main
Are you sure you want to change the base?
Conversation
This is a 1:1 clone of VecView
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
fn SHA1::make(Bytes) -> SHA1 | ||
fn SHA1::update(SHA1, Bytes) -> Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These Bytes
are ideally @mem.Loadable
, refs moonbitlang/moonbit-docs#190
) -> Unit { | ||
for i = 0; i < n_blocks; i = i + 1 { | ||
let l = (blocks[i * 64..]) as @mem.Loadable | ||
let [ ha, hb, hc, hd, he, .. ] = h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is raising a warning that I don't understand:
core/hash/sha1.mbt:48:38-48:39 Warning 011: Partial match, some hints:
[ ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it means that h
may be empty
we would like to have this package landed, could it be submitted as a standalone PR independently |
Sure, tho I'm outta town for 2 weeks, I can only reply to messages. Feel free to push to my branch, or cherry-pick in whatever way the team prefers, if it's too long to wait for 2 weeks. Thank you and sorry for the inconvenience! |
Depends on:
@mem
package #329