add multi backend support for fs io #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need bleeding moonrun to run test |
lijunchen
reviewed
Sep 23, 2024
Young-Flash
commented
Sep 23, 2024
| @@ -60,7 +60,6 @@ jobs: | |||
| git diff --exit-code | |||
|
|
|||
| coverage-check-bleeding: | |||
| if: false | |||
lijunchen
approved these changes
Sep 23, 2024
fs/fs.mbt
Outdated
| /// A `String` containing the file contents if the file exists, otherwise raises an error. | ||
| pub fn read_file_to_string(~path : String) -> String! { | ||
| guard path_exists(~path) else { | ||
| raise IOError::NotFound("file `\{path}` does not exist") |
There was a problem hiding this comment.
raise IOError::NotFound(path) is enough here. We can customize the Show trait for IOError to reduce redundant error messages.
Young-Flash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.