Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a toggle button to the resolutions #30

Closed
Aamir3d opened this issue Aug 28, 2023 · 5 comments
Closed

Adding a toggle button to the resolutions #30

Aamir3d opened this issue Aug 28, 2023 · 5 comments

Comments

@Aamir3d
Copy link

Aamir3d commented Aug 28, 2023

There are a bunch of resolutions / image sizes , but as we can see now, the dropdown is TOO long.
I propose having either a toggle button for landscape/ portrait mode or an aspect ratio button to quickly switch without getting bogged down in the long dropdown.

image

image

Addendum.
I don't see any 16:9 / 9:16 ratios or 16:10, which are pretty common and widely used. For example
I feel those are necessary additions and should have been part of the original project too.

I've calculated some resolutions that might be useful
1152 x 720 - 16:10
1152 x 648 - 16:9
1280x720 - 16:9

Edit 2:
(Note from the GUI perspective - the dropdown is indeed way too long now, and serves as a distraction rather than a 'quick' generation.
For other members contributing to the project, it might be helpful to discuss / see if it might be more feasible to say enter a width or height value, and use the toggle to fill in the other resolution based on aspect, or just enter values in both fields (faster).

@barepixels
Copy link

1152 x 720 - 16:10
1152 x 648 - 16:9
1280x720 - 16:9
do not use. 720 and 648 does not divided by 64 evenly

Use 1344 x 768 for 16:9

@Aamir3d
Copy link
Author

Aamir3d commented Aug 28, 2023

1152 x 720 - 16:10 1152 x 648 - 16:9 1280x720 - 16:9 do not use. 720 and 648 does not divided by 64 evenly

Use 1344 x 768 for 16:9

Interesting, thank you for the info.

@MoonRide303
Copy link
Owner

@Aamir3d The resolution list is limited on purpose - I wanted it to be in sync with officially supported resolutions list used for SDXL training (as defined in SDXL paper, Appendix I). And as Gradio (UI framework used by Fooocus) doesn't support that kind of toggles / filters for dropdown lists, I am leaving resolution list as it is - closing.

@Aamir3d
Copy link
Author

Aamir3d commented Aug 29, 2023

No problem.
Just asking - is there a possibility to include a resolution box instead - this is because just scrolling through the list trying to find a resolution/aspect you need is a waste of time (which defeats the purpose of having a simple clean UI).
Maybe do a Resolution X Resolution Y box, and display resolutions below in the dropdown.

@barepixels
Copy link

There are a lot of resolutions on that list that nobody would ever use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants