Add tooltip #133
Merged
Add tooltip #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xordist LMKYT on this |
hmrtn
requested changes
Feb 7, 2022
| <Text color={headingColor} fontSize="5xl"> | ||
| pay.party | ||
| <Tooltip label="Tool to distribute compensation to team members based on democratic principles"> |
There was a problem hiding this comment.
I do not think this is a necessary tooltip and should probably be removed before merging.
| @@ -121,7 +122,7 @@ const Create = ({ address, mainnetProvider, userSigner, tx, readContracts, write | |||
| /> | |||
| </Box> | |||
| <FormLabel pl="2" pt="2"> | |||
| Voters:{" "} | |||
| <Tooltip label="Voters are persons who vote for the candidates">Voters: </Tooltip> | |||
There was a problem hiding this comment.
It would be great to see this (and the other labels) have a small question mark button next to the text, that on hover shows helpful information e.g see icons: https://chakra-ui.com/docs/media-and-icons/icon
There was a problem hiding this comment.
I've added a question mark icon that will show the tooltip on hover. LMK if more changes are required
hmrtn
previously approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
This is a draft PR. Feel free to suggest changes and improvements