Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confetti on vote #166

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Add confetti on vote #166

merged 2 commits into from
Mar 12, 2022

Conversation

Dhaiwat10
Copy link
Member

Closes #163

This solution is a bit hacky but it'll work. We are attaching a query param confetti to the URL and displaying confetti for 10 seconds based off of that.

@Dhaiwat10 Dhaiwat10 requested a review from hmrtn March 10, 2022 12:52
@hmrtn
Copy link
Member

hmrtn commented Mar 12, 2022

Looks good! But in the future, we should utilize the contract events instead of relying on hard page refreshes.

@hmrtn hmrtn merged commit 415bc4c into develop Mar 12, 2022
@Dhaiwat10
Copy link
Member Author

we should utilize the contract events instead of relying on hard page refreshes.

Didn't think of that. Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confetti
2 participants