contract clean up for distribution #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmrtn
reviewed
Dec 28, 2021
| total += values[i]; | ||
| } | ||
|
|
||
| require(msg.value >= total, "Not enough Ether to distribute"); |
There was a problem hiding this comment.
Could just be a hardhat node thing, but this requirement breaks the current tests in the latest tests on the dev branch
hmrtn
reviewed
Dec 28, 2021
| require(token.transfer(recipients[i], values[i])); | ||
|
|
||
| function distributeToken( | ||
| IERC20 token, |
There was a problem hiding this comment.
ERC20 implements the internal method _transfer(address sender, address recipient, uint256 amount) with requirements about spenders balances, null addresses, and allowances. Does that make these requirements redundant?
hmrtn
reviewed
Dec 28, 2021
hmrtn
approved these changes
Dec 28, 2021
farque65
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.