Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict access to request signatures with resources #23

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Restrict access to request signatures with resources #23

merged 5 commits into from
Dec 14, 2023

Conversation

kompotkot
Copy link
Collaborator

No description provided.

@kompotkot kompotkot mentioned this pull request Dec 13, 2023
Open
4 tasks
zomglings
zomglings approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to deploy this, but I do believe the comments I made to be significant. If you don't fix them in this PR, maybe create issues?

server.go Outdated Show resolved Hide resolved
server.go Outdated
return
}

server.signDropperRoute(w, r, signer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does net/http have something like FastAPI applications? So you could define a sub-mux or something?

@kompotkot kompotkot merged commit 3b1daea into main Dec 14, 2023
1 check passed
@kompotkot kompotkot deleted the resource-control branch December 14, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomglings zomglings zomglings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kompotkot @zomglings