Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard.removeEvents() doesn't work #1083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keyboard.removeEvents() doesn't work #1083

wants to merge 1 commit into from

Commits on Dec 16, 2011

  1. Keyboard.addEvent calls parent() with a parsed event type. When remov… 

    …eEvents is called, it will call removeEvent with the already parsed event type. We cannot call Keyboard.parse() inside of removeEvent because then we would be parsing an already parsed event type.

I don't really like my fix, as it means that an argument to Keyboard.addEvent() is not a valid argument to Keyboard.removeEvent. I'm not sure what the best fix to this problem is, however.
    @jfly
    jfly committed Dec 16, 2011
    Configuration menu
    Copy the full SHA
    98eeffc View commit details
    Browse the repository at this point in the history