Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Creation - Merge Files #529

Closed
wadearnold opened this issue Apr 30, 2019 · 2 comments
Closed

File Creation - Merge Files #529

wadearnold opened this issue Apr 30, 2019 · 2 comments
Assignees

Comments

@wadearnold
Copy link
Member

A utility function should exist that takes an array of ACH.Files and merges them into one or many files. If the merged file exceeds the NACHA record limit limitation of 10k entries and the additional file should be created.

@adamdecaf adamdecaf self-assigned this Apr 30, 2019
@adamdecaf
Copy link
Member

adamdecaf commented May 22, 2019

// MergeFiles is a helper function for consolidating an array of ACH Files into as few files
// as possible. This is useful for optimizing cost and network efficiency.
//
// Per NACHA rules files must remain under 10,000 lines (when rendered in their ASCII encoding)
//
// File Batches can only be merged if they are unique and routed to and from the same ABA routing numbers.
func MergeFiles(files []*File) ([]*File, error) { ... }

@wadearnold and/or @bkmoovio would you have other comments to add here?

I'm going to use some of paygate's mergeTransfer logic and line count wrapper for this.

adamdecaf added a commit to adamdecaf/ach that referenced this issue May 22, 2019
@bkmoovio
Copy link
Contributor

I think it’s good. Wade can probably chime in on if any specific additional requirements are needed. It’s great if you can leverage what you did in paygate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants