Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: remove test containers based on dockertest #223

Merged
merged 2 commits into from
May 3, 2022

Conversation

adamdecaf
Copy link
Member

No description provided.

@adamdecaf adamdecaf requested a review from InfernoJJ as a code owner May 2, 2022 22:36
InfernoJJ
InfernoJJ previously approved these changes May 3, 2022
alovak
alovak previously approved these changes May 3, 2022
@adamdecaf adamdecaf dismissed stale reviews from alovak and InfernoJJ via bfe862e May 3, 2022 14:04
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #223 (2f449af) into master (172fcc6) will decrease coverage by 3.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   81.10%   77.84%   -3.26%     
==========================================
  Files          29       29              
  Lines        1032      930     -102     
==========================================
- Hits          837      724     -113     
- Misses        133      161      +28     
+ Partials       62       45      -17     
Impacted Files Coverage Δ
database/mysql.go 31.76% <ø> (-34.02%) ⬇️
database/database.go 26.19% <0.00%> (-14.29%) ⬇️
database/migrator.go 50.00% <0.00%> (-12.00%) ⬇️
database/sqlite_cgo.go 65.67% <0.00%> (-7.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172fcc6...2f449af. Read the comment docs.

@adamdecaf adamdecaf requested review from alovak and InfernoJJ May 3, 2022 14:20
@adamdecaf adamdecaf merged commit 079b5b9 into master May 3, 2022
@adamdecaf adamdecaf deleted the remove-dockertest branch May 3, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants