do not ignore error when walk dir in pkger #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
pkger
Why:
Currently, we ignore the error when pkger walks the migration directory and the migration file name does not match the expected format. When such happens it stops adding the rest of the files. In our case with manual migrations, we named the file in a way so golang-migrate will ignore it: we just removed
.up
part. But, we didn't know that we have one more layer of file format checking :(P.S. we should not check file name format here and delegate it to golang-migrate