Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: overwrite slices instead of merging #281

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

InfernoJJ
Copy link
Member

Previously it was causing issues with merging arrays where if the new array being merged wasn't bigger than the old one values would stick around. This hopefully fixes that

…ausing issues with merging arrays where if the new array being merged wasn't bigger than the old one values would stick around. This hopefully fixes that
@adamdecaf adamdecaf changed the title fixing some minor issues with the config merging. config: overwrite slices instead of merging Apr 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (24e3aee) 75.65% compared to head (ecf2f73) 75.80%.

❗ Current head ecf2f73 differs from pull request most recent head 5e510c0. Consider uploading reports for the commit 5e510c0 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   75.65%   75.80%   +0.15%     
==========================================
  Files          28       28              
  Lines         920      926       +6     
==========================================
+ Hits          696      702       +6     
  Misses        178      178              
  Partials       46       46              
Impacted Files Coverage Δ
config/config.go 76.74% <100.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InfernoJJ InfernoJJ merged commit 90c1fde into master Apr 11, 2023
@InfernoJJ InfernoJJ deleted the fix-config-array-merge branch April 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants