Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add orderBy param #324

Merged
merged 4 commits into from
Sep 26, 2023
Merged

add orderBy param #324

merged 4 commits into from
Sep 26, 2023

Conversation

michaelabbott25
Copy link
Contributor

@michaelabbott25 michaelabbott25 commented Sep 25, 2023

adding the orderBy param that way it's reusable and consistent if/when we add new endpoints that use ordering. this is similar to how we handle paging.

@michaelabbott25 michaelabbott25 changed the title add sortBy and order params add sort-by and order params Sep 25, 2023
@InfernoJJ
Copy link
Member

InfernoJJ commented Sep 25, 2023

I would get rid of the semi-confusing exists boolean being returned. We make all the values lowercase kabob formatted. So createdOn to created-on etc... This helps our customers who are developing against the platform to avoid mistakes.

LGTM otherwise!

@michaelabbott25 michaelabbott25 changed the title add sort-by and order params add sortBy and order params Sep 25, 2023
@michaelabbott25 michaelabbott25 changed the title add sortBy and order params add orderBy param Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ed4abd5) 76.11% compared to head (e52f4f4) 76.78%.

❗ Current head e52f4f4 differs from pull request most recent head e1d2fd3. Consider uploading reports for the commit e1d2fd3 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   76.11%   76.78%   +0.66%     
==========================================
  Files          28       28              
  Lines        1005     1034      +29     
==========================================
+ Hits          765      794      +29     
  Misses        178      178              
  Partials       62       62              
Files Coverage Δ
http/server.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InfernoJJ InfernoJJ merged commit 52aa0f2 into moov-io:master Sep 26, 2023
8 checks passed
@michaelabbott25 michaelabbott25 deleted the add-sorting-params branch September 26, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants