Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

List customers with sorting and filtering #128

Closed
joshsadler opened this issue Aug 26, 2020 · 3 comments · Fixed by #144
Closed

List customers with sorting and filtering #128

joshsadler opened this issue Aug 26, 2020 · 3 comments · Fixed by #144
Assignees
Labels
enhancement New feature or request

Comments

@joshsadler
Copy link
Member

Related to #99

For customer management, it'd be useful to extend the functionality of the GET /customers endpoint.

Consider having GET /customers return a paginated list of results. My immediate need is for the sort order to be by date created.

For any paginated response, it's useful to know when you've hit the end of the series by either having the total count in the response or a marker on the response to signal the end.

We could do this in all sorts of ways, but typical REST might be something like

GET /customers?orderBy=createdAt&orderDirection=desc&limitTo=50

Also related, filtering the list of customers by status and createdAt (before or after), would be a solid start.

@adamdecaf
Copy link
Member

@jmbrown412 can we include a filter for type that returns only individual or business Customers if specified. It was on #99 but I don't think we've gotten to it yet.

@jmbrown412
Copy link
Contributor

This isn't done but I can prioritize that tomorrow first thing. Should be quick to do.

@jmbrown412
Copy link
Contributor

This isn't done but I can prioritize that tomorrow first thing. Should be quick to do.

This was just merged. You can search for customers by type now.
Examples:
?type=individual
?type=business

@adamdecaf adamdecaf moved this from In progress to Done in Current Work Sep 10, 2020
@jmbrown412 jmbrown412 linked a pull request Sep 22, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Current Work
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants