This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Update customer search functionality to allow searching for Customer by Status. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfernoJJ
approved these changes
Sep 2, 2020
cmd/server/customer_search.go
Outdated
| @@ -101,5 +103,9 @@ func buildSearchQuery(params searchParams) (string, []interface{}) { | |||
| query += " and lower(email) like ?" | |||
| args = append(args, "%"+strings.ToLower(params.Email)) | |||
| } | |||
| if params.Status != "" { | |||
| query += " and status like ?" | |||
| args = append(args, "%"+strings.ToLower(params.Status)) | |||
There was a problem hiding this comment.
No need to double toLower since we do it up above when we create the params.
There was a problem hiding this comment.
Good catch. I removed them for all of the query params.
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 62.20% 62.18% -0.03%
==========================================
Files 36 36
Lines 1982 1986 +4
==========================================
+ Hits 1233 1235 +2
- Misses 530 531 +1
- Partials 219 220 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the search functionality for Customers to allow searching by Status.
Issue: #128