Add "Too new to rate" status to Payment History Profile #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
approved these changes
May 31, 2023
|
Looks simple enough to me. Thanks for contributing! |
|
@jamierajewski can you try updating the library in your project? |
|
We were actually using a fork of the library so I need to swap it out with the original. It might be a little while before we can do that as there were a few other changes made that I need to compare to the original and see if I need to put up anymore consistency PR's |
|
Okay sounds good. We'd be happy to accept more fixes for metro2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on a Canadian credit reporting product, and while consulting the Canadian Metro2 documentation from Equifax we found that there is a payment history profile status missing in this library that we require -
Too New To Rate, status codeZ.I have added it alongside the other payment history profile statuses, and added it to the validator which I believe should be sufficient, but please let me know if there is more to this.
I also can't link to the documentation as it is a private PDF from Equifax; I'm not sure if any confirmation of this is required but if it is I'll have to find a way to present it.
@adamdecaf tagging you as the most recent author I see contributing since this is a trivial PR