Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow linked-from to get id in image fetching (fixes #171) #245

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

adamcik
Copy link
Member

@adamcik adamcik commented Dec 19, 2019

No description provided.

@adamcik adamcik added C-bug Category: This is a bug A-webapi Area: Spotify Web API labels Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #245 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   96.76%   96.76%   +<.01%     
==========================================
  Files          13       13              
  Lines        1174     1176       +2     
==========================================
+ Hits         1136     1138       +2     
  Misses         38       38
Impacted Files Coverage Δ
mopidy_spotify/images.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e82e54...66652c3. Read the comment docs.

@kingosticks kingosticks added this to the v4.0 milestone Dec 19, 2019
@kingosticks
Copy link
Member

LGTM once black passes

@adamcik adamcik merged commit 33ebddc into mopidy:master Dec 19, 2019
@adamcik adamcik deleted the fix-171 branch December 19, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webapi Area: Spotify Web API C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants