Reimplement most .off() variants #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease migration from Mopidy 0.5, this reimplements the various ways of calling `.off()` that can easily be implemented using `.removeAllListeners()` and `.removeListener`().
jodal
force-pushed
the
jodal/better-off
branch
from
ed9032b
to
58b76bf
Compare
tkem
reviewed
Nov 22, 2018
There was a problem hiding this comment.
Looks good. I only use mopidy.off() when switching servers in the MoMo app, so I only tested the off method without parameters. I think removing any references to Node.js from the changelog will also avoid some confusion ("do I need Node.js to use mopidy.js?").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease migration from Mopidy 0.5, this reimplements the various ways of calling
.off()that can easily be implemented using.removeAllListeners()and.removeListener().@tkem Re #17, does this ease the migration from v0.5 for you?