Cleaned up version of #558 - Add avahi publishing of MPD and HTTP server endpoints. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rudimentary implementation to resolve mopidy#39, ignoring dbus errors (just restart), name collisions (choose a fresh name), etc.
- Prepare for handling missing dbus directly in module. - Constants should always be all caps. - Extracted helpers from class to convey intent via their naming. - Moved imports out of class, imports should always be on the top. - Made sure calling publish mutiple times does not re-convert text. - Made sure calling unpublish without publish does not break.
- Handle dbus not being installed. - Handle not finding the system bus. - Handle not finding the avahi service. - Return if publish succeeded.
- Move imports to top as they should be. - Report state based on publish return value. - Remove overly broad except clauses. - Unpublish before stopping servers.
| def on_start(self): | ||
| if self.config_section['zeroconf']: | ||
| self.zeroconf_service = zeroconf.Zeroconf( | ||
| stype="_mpd._tcp", name=self.config_section['zeroconf'], |
|
+1 with comments |
- Switched to newstyle class - Switched to safe values in kwargs
|
Found some more things that needed fixing, but should be good now. |
| @@ -17,6 +17,10 @@ def __init__(self, config, core): | |||
| super(MpdFrontend, self).__init__() | |||
| hostname = network.format_hostname(config['mpd']['hostname']) | |||
| port = config['mpd']['port'] | |||
| self.config_section = config['mpd'] | |||
There was a problem hiding this comment.
Might it be neater to do this first and use self.config_section to get the host and port above (like the http frontend does)? In fact, why not just assign straight to self.hostname and self.port while you're at it?
jodal
added a commit
that referenced
this pull request
Nov 11, 2013
Cleaned up version of #558 - Add avahi publishing of MPD and HTTP server endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.