Create dedicated setup type for SetupAllProperties
#1234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1204, where a dedicated setup type was created for single stubbed properties' accessors (i.e.
SetupProperty
). Thanks to #1203, the same can also be done forSetupAllProperties
.A few additional notes:
This gets rid of the
RemoveAllPropertyAccessorSetups
method inSetupCollection
, restoring it to an add-only collection, which in turn means its use oflock
-ing could be optimized in a similar fashion as was done forInvocationCollection
.Gets rid of the
AutoSetupPropertiesDefaultValueProvider
hack and simplifies the interception pipeline.Moq should become a little more efficient in principle, since there will be fewer setups created overall.
Fixes #1066, likely fixes #1231.