Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add STTE for older target frameworks only #1274

Merged
merged 1 commit into from
Aug 2, 2022
Merged

add STTE for older target frameworks only #1274

merged 1 commit into from
Aug 2, 2022

Conversation

tibel
Copy link
Contributor

@tibel tibel commented Aug 2, 2022

Add System.Threading.Tasks.Extensions reference conditionally to reduce dependencies on newer frameworks.

stakx
stakx approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I like this! We've had so many versioning issues caused by this package in the past, I'm glad to see this go (at least for the newer TFMs). Thanks!

@stakx stakx merged commit e2460df into devlooped:main Aug 2, 2022
@tibel tibel deleted the conditional-STTE branch August 2, 2022 17:38
@stakx stakx added this to the 4.18.2 milestone Aug 2, 2022
@stakx
Copy link
Contributor

stakx commented Aug 2, 2022

@tibel, FYI, I've just pushed Moq version 4.18.2 to NuGet, which includes this change.

@devlooped devlooped locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stakx stakx stakx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.18.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tibel @stakx