Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Window, WindowLeft & WindowRight implementation internally #630

Open
Orace opened this issue Nov 1, 2019 · 1 comment
Open

Share Window, WindowLeft & WindowRight implementation internally #630

Orace opened this issue Nov 1, 2019 · 1 comment

Comments

@Orace
Copy link
Contributor

Orace commented Nov 1, 2019

This is a fork of #629 and #627.

We should introduce a private method to share the implementation among the three Window* methods.

@atifaziz atifaziz changed the title Window, WindowLeft and WindowRight implementation should be shared Share Window, WindowLeft & WindowRight implementation internally Nov 2, 2019
@atifaziz
Copy link
Member

atifaziz commented Nov 2, 2019

I haven't done a study of whether it would help or not but if you'd like to take a crack at this through a PR then I'd be happy to review it. If you'd rather that I first do a study and accept this with conviction (so you don't risk wasting time with work that may not get merged) then you'll have to be patient as this is not going to be a high priority for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants