Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for get_template_from_string() #4

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

CLiu13
Copy link
Collaborator

@CLiu13 CLiu13 commented Jan 20, 2019

With this addition, moban-handlebars will be compatible with moban 0.3.8.

Closes #1

@CLiu13 CLiu13 force-pushed the string-template branch 2 times, most recently from f1d4f82 to e7f7ed3 Compare January 20, 2019 04:26
With this addition, moban-handlebars will be compatible with moban 0.3.8.

Closes moremoban#1
@codecov-io
Copy link

codecov-io commented Jan 20, 2019

Codecov Report

Merging #4 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev     #4   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         4      4           
  Lines        46     61   +15     
===================================
+ Hits         46     61   +15
Impacted Files Coverage Δ
moban_handlebars/engine.py 100% <100%> (ø) ⬆️
tests/test_handlebar_engine.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bc1b3...487197a. Read the comment docs.

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@chfw chfw merged commit 4e17384 into moremoban:dev Jan 20, 2019
@chfw
Copy link
Member

chfw commented Jan 20, 2019

fyi, no need to fork it as you are a collaborator of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants