Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 🚜 refactored tests #317

Merged
merged 8 commits into from
Aug 21, 2019
Merged

🔨 🚜 refactored tests #317

merged 8 commits into from
Aug 21, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Aug 20, 2019

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you pround of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #317 into dev will decrease coverage by 2.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
- Coverage   97.89%   95.36%   -2.53%     
==========================================
  Files          62       50      -12     
  Lines        2892     2504     -388     
==========================================
- Hits         2831     2388     -443     
- Misses         61      116      +55
Impacted Files Coverage Δ
tests/utils.py 100% <100%> (ø)
tests/test_docs.py 100% <100%> (ø) ⬆️
tests/test_regression.py 100% <100%> (+20.58%) ⬆️
tests/test_copy_engine.py 100% <100%> (ø) ⬆️
moban/jinja2/filters/text.py 18.18% <0%> (-81.82%) ⬇️
moban/jinja2/filters/github.py 32.35% <0%> (-67.65%) ⬇️
moban/jinja2/filters/repr.py 50% <0%> (-50%) ⬇️
moban/core/moban_factory.py 89.04% <0%> (-10.28%) ⬇️
moban/deprecated/__init__.py 88.37% <0%> (-8.14%) ⬇️
moban/utils.py 92.85% <0%> (-3.58%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb867a...c7ce980. Read the comment docs.

@chfw chfw merged commit e5c26b0 into dev Aug 21, 2019
@chfw chfw deleted the refactor-tests branch August 21, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants