Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended override #321

Merged
merged 6 commits into from
Aug 23, 2019
Merged

Extended override #321

merged 6 commits into from
Aug 23, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Aug 23, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

delivers #126

@chfw chfw requested review from jayvdb and ayan-b August 23, 2019 08:09
@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #321 into dev will decrease coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #321      +/-   ##
=========================================
- Coverage   95.4%   95.35%   -0.06%     
=========================================
  Files         50       50              
  Lines       2505     2517      +12     
=========================================
+ Hits        2390     2400      +10     
- Misses       115      117       +2
Impacted Files Coverage Δ
moban/data_loaders/manager.py 95% <85.71%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df830b6...1ac78ae. Read the comment docs.

@chfw chfw merged commit 930a34f into dev Aug 23, 2019
@chfw chfw deleted the extended-override branch September 19, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants