Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-D hello=world is added. #324

Merged
merged 4 commits into from
Aug 29, 2019
Merged

-D hello=world is added. #324

merged 4 commits into from
Aug 29, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Aug 28, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

resolves #256

@chfw chfw requested a review from jayvdb August 28, 2019 22:57
@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #324 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #324      +/-   ##
==========================================
+ Coverage   95.35%   95.39%   +0.04%     
==========================================
  Files          50       51       +1     
  Lines        2517     2542      +25     
==========================================
+ Hits         2400     2425      +25     
  Misses        117      117
Impacted Files Coverage Δ
tests/test_docs.py 100% <100%> (ø) ⬆️
moban/core/context.py 100% <100%> (ø) ⬆️
moban/program_options.py 100% <100%> (ø)
moban/main.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d28ccd...cc8d1f1. Read the comment docs.

@chfw chfw changed the title -D is added. -D hello=world is added. Aug 28, 2019
@chfw chfw merged commit ff18b41 into dev Aug 29, 2019
@chfw
Copy link
Member Author

chfw commented Sep 9, 2019

Please note: -D was renamed to use -d in version 0.6.0

-D never entered in use.

@chfw chfw deleted the cli-define branch September 19, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jinja2-cli parity: '-D' to define custom variable on cli
3 participants