Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: tag coloring #357

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uiw6unoh
Copy link

Description

image

I discovered an attractive feature discussed in issue #81 which had not yet been implemented.
I have adapted this feature to fit the latest codebase.

Related tickets

#81

PR Checklist

Copy link

vercel bot commented Apr 26, 2024

@uiw6unoh is attempting to deploy a commit to the morethanmin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
morethan-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 3:35pm

@morethanmin morethanmin self-requested a review April 28, 2024 15:33
@uiw6unoh uiw6unoh removed their assignment Apr 29, 2024
@uiw6unoh uiw6unoh closed this May 8, 2024
@uiw6unoh uiw6unoh deleted the feature/tag-coloring branch May 8, 2024 08:59
@uiw6unoh uiw6unoh restored the feature/tag-coloring branch May 9, 2024 04:10
@uiw6unoh uiw6unoh reopened this May 9, 2024
@uiw6unoh uiw6unoh changed the title [feat]: Tag Coloring [feat]: tag coloring May 10, 2024
Copy link
Owner

@morethanmin morethanmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 PR 남겨주셔서 정말 감사드립니다! 리뷰가 늦어졌네요.

기존 카테고리 색상의 경우 같은 문자열에 대해 같은 색상이 적용되었는데, 해당 로직은 순서에 따라 색상이 적용되고 있네요.

같은 태그이더라도 순서에 따라 다른 색상이 적용된다면 다른 태그라고 인식할 수 있을 것 같습니다.

따라서 카테고리에 적용된 로직이 동일하게 적용되도록 수정되면 좋을 것 같습니다.

@uiw6unoh
Copy link
Author

태그 문자열에 기반한 해시 함수를 추가하였습니다!😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants