Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/generic parser combinators` #31

Merged
merged 8 commits into from
Jun 15, 2019

Conversation

mori0091
Copy link
Owner

@mori0091 mori0091 commented Jun 15, 2019

(3/3 of #28 )

  • added PARSER(List(String)) and PARSER(List(Int))
  • made built-in parser-combinators more generic (in progress)
    • many(p)
    • many1(p)
    • seq(p, ...)
    • cons(p, ps)

- PARSER(String) many(PARSER(Char) p)
- PARSER(List(String)) many(PARSER(String) p)
- PARSER(List(Int)) many(PARSER(Int) p)
@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #31 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   98.48%   98.72%   +0.23%     
==========================================
  Files          59       58       -1     
  Lines        1652     1724      +72     
==========================================
+ Hits         1627     1702      +75     
+ Misses         25       22       -3
Impacted Files Coverage Δ
include/cparsec2.hpp 100% <100%> (ø) ⬆️
test/src/test_many.cpp 100% <100%> (ø) ⬆️
src/many.c 100% <100%> (ø) ⬆️
src/parse.c 89.7% <100%> (+1.57%) ⬆️
src/many1.c 100% <100%> (ø) ⬆️
test/src/test_many1.cpp 100% <100%> (ø) ⬆️
src/main.c 100% <100%> (ø) ⬆️
src/skip1st.c 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9ca10...5310522. Read the comment docs.

@mori0091
Copy link
Owner Author

Please click "Ready for review" and we merge to master soon.
Then start last two refactoring on another new branch/fork.

  • refactor for seq(p, ...) and cons(p, ps); make them more generic.

@mori0091 mori0091 marked this pull request as ready for review June 15, 2019 05:16
@mori0091 mori0091 merged commit 37f4b45 into master Jun 15, 2019
@mori0091 mori0091 deleted the feature/generic_parser-combinators branch June 15, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant