Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generic seq(p,...) #32

Merged
merged 2 commits into from
Jun 15, 2019
Merged

refactor: generic seq(p,...) #32

merged 2 commits into from
Jun 15, 2019

Conversation

mori0091
Copy link
Owner

(relative to #28 )

  • PARSER(List(Char)) seq(PARSER(Char) p, ...)
  • PARSER(List(String)) seq(PARSER(String) p, ...)
  • PARSER(List(Int)) seq(PARSER(Int) p, ...)

@mori0091
refactor: generic seq(p,...)
33bf04f 
- PARSER(List(Char)) seq(PARSER(Char) p, ...)
- PARSER(List(String)) seq(PARSER(String) p, ...)
- PARSER(List(Int)) seq(PARSER(Int) p, ...)
@codecov
Copy link

codecov bot commented Jun 15, 2019 •
edited
Loading

Codecov Report

Merging #32 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.72%   98.73%   +<.01%     
==========================================
  Files          58       58              
  Lines        1724     1736      +12     
==========================================
+ Hits         1702     1714      +12     
  Misses         22       22
Impacted Files Coverage Δ
include/cparsec2.hpp 100% <100%> (ø) ⬆️
test/src/test_seq.cpp 100% <100%> (ø) ⬆️
src/seq.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f4b45...a80abbb. Read the comment docs.

@mori0091 mori0091 marked this pull request as ready for review June 15, 2019 12:17
@mori0091
Copy link
Owner Author

Accepted.

@mori0091 mori0091 merged commit 30a22c6 into master Jun 15, 2019
@mori0091 mori0091 deleted the feature/generic_parser-combinators2 branch June 15, 2019 12:23
@mori0091 mori0091 mentioned this pull request Jun 15, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mori0091