Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename get_ssm_by_sample arg to this_sample_id #45

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Rename get_ssm_by_sample arg to this_sample_id #45

merged 1 commit into from
Nov 30, 2023

Conversation

vladimirsouza
Copy link
Contributor

In GAMBLR.results, get_ssm_by_sample uses this_sample_id (both singular) and get_ssm_by_samples uses these_sample_ids (both plural), which makes sense. In GAMBLR.data, get_ssm_by_samples does use these_sample_ids, but get_ssm_by_sample uses these_sample_ids

In this PR, I rename get_ssm_by_sample's argument to this_sample_id.

@vladimirsouza vladimirsouza mentioned this pull request Nov 28, 2023
Closed
@vladimirsouza vladimirsouza mentioned this pull request Nov 28, 2023
Merged
mattssca
mattssca approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mattssca mattssca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work as advertised, thanks for the PR.

@vladimirsouza vladimirsouza merged commit b6abbc8 into master Nov 30, 2023
@vladimirsouza vladimirsouza deleted the vsouza-fix_get_ssm_by_sample_parameter branch November 30, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattssca mattssca mattssca approved these changes

@Kdreval Kdreval Awaiting requested review from Kdreval

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimirsouza @mattssca