-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unar
#1833
Comments
I'm open to a PR dealing with this. Maybe having a command line argument to use unar. You have to deal with this in bazarr.init.init_binaries() but also in libs.subliminal_patch.providers.* and subzero. I would use an env variable to pass the unar usage boolean to those two modules. |
Sounds good. I looked at submitting a PR myself, and I fixed it in |
I'll close this one while waiting for your PR. |
@morpheus65535 Ah, I think you misunderstood. I didn't know how to create a PR. I had no idea what to do with patching those dependencies. I mean, I could have done something very hacky, but would rather not! |
Should be good in upcoming beta. |
@morpheus65535 Thanks! |
The latest
rarfile
package has support for using theunar
insterad of theunrar
program. I believe you already use this in the master branch. Could we add support to use unar, please? Ideally both as a fallback forunrar
, as well as setting an environment variable, e.g.UNRAR_TOOL=unrar
vs.UNRAR_TOOL=urar
. This would be the final hurdle to overcome for getting my macOS Homebrew formula accepted.The text was updated successfully, but these errors were encountered: