Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unar #1833

Closed
alexreg opened this issue May 7, 2022 · 6 comments
Closed

Support unar #1833

alexreg opened this issue May 7, 2022 · 6 comments

Comments

@alexreg
Copy link
Contributor

alexreg commented May 7, 2022

The latest rarfile package has support for using the unar insterad of the unrar program. I believe you already use this in the master branch. Could we add support to use unar, please? Ideally both as a fallback for unrar, as well as setting an environment variable, e.g. UNRAR_TOOL=unrar vs. UNRAR_TOOL=urar. This would be the final hurdle to overcome for getting my macOS Homebrew formula accepted.

@morpheus65535
Copy link
Owner

I'm open to a PR dealing with this. Maybe having a command line argument to use unar. You have to deal with this in bazarr.init.init_binaries() but also in libs.subliminal_patch.providers.* and subzero. I would use an env variable to pass the unar usage boolean to those two modules.

@alexreg
Copy link
Contributor Author

alexreg commented May 8, 2022

Sounds good. I looked at submitting a PR myself, and I fixed it in init_binaries, but wasn't sure the best way to patch subliminal & subzero. I agree, an env var is the best way to deal with this.

@morpheus65535
Copy link
Owner

I'll close this one while waiting for your PR.

@alexreg
Copy link
Contributor Author

alexreg commented May 13, 2022

@morpheus65535 Ah, I think you misunderstood. I didn't know how to create a PR. I had no idea what to do with patching those dependencies. I mean, I could have done something very hacky, but would rather not!

@morpheus65535
Copy link
Owner

Should be good in upcoming beta.

@alexreg
Copy link
Contributor Author

alexreg commented May 18, 2022

@morpheus65535 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants