Upgrade mantine to v7.x #2465
Merged
Upgrade mantine to v7.x #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morpheus65535 The PR is ready, but would be great if i can have some help for review and QA before merging. |
|
@morpheus65535 I applied some changes to make it closer to what we have now without having to hack and get screwed during the next updates. |
|
Let me do some extra refactorings here, also there is one bug on the sync subtitle modal. Converting it to Draft. |
anderson-oki
commented
May 24, 2024
frontend/package.json
Outdated
| "@mantine/hooks": "^6.0.21", | ||
| "@mantine/modals": "^6.0.21", | ||
| "@mantine/notifications": "^6.0.21", | ||
| "@mantine/core": "^7.8.0", |
There was a problem hiding this comment.
We should bump this again and test before merging.
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main change on the Mantine V7 is that they removed the usage of Emotion and now all the customizations diretly from CSS in JS is not recommended, instead we should either use CSS Modules or start using another dependency such as Vannila-Extract. We can discuss later on adding Vannila-Extract, however i would recommend to keep focusing on Mantine and their recommendations, otherwise future updates might be even more terrifying.
Changes
table,thead,trandtdall have its own components from Mantine.Next Steps
MultiSelectorPropswas a little bit more fancy as it displayed some advices instead of just the default behavior of pressing Enter which is probably more intuitive. The current TagsInput keeps the same functionality but would be nice to have our own custom MultiSelector. To minimize the changes i prefer to do in a different PR once this one is merged.