feat(oracle): add oracle wrappers #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
force-pushed
the
feat/oracle-wrappers
branch
from
6d2a660
to
359f412
Compare
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
pakim249CAL
reviewed
Jul 24, 2023
| @@ -2,5 +2,5 @@ | |||
| pragma solidity >=0.5.0; | |||
|
|
|||
| interface IOracle { | |||
| function price() external view returns (uint256); | |||
| function price() external view returns (uint256 borrowablePrice, bool canBorrow, bool canWithdraw); | |||
There was a problem hiding this comment.
I would prefer to see canBorrow and canWithdraw to be flipped to borrowPaused and withdrawPaused (or something similar), as the default value of these should be to allow these interactions.
Also, the naming of canWithdraw in this interface is not consistent with canWithdrawCollateral in Blue.
There was a problem hiding this comment.
One could argue that it's "safer" to require a non-default value for these flags though. I'm ok with both anyway!
pakim249CAL
approved these changes
Jul 31, 2023
Rubilmax
force-pushed
the
feat/single-oracle
branch
from
1a3bb68
to
5cbe214
Compare
|
Moved to periphery repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a first step to discuss further the topic of oracles. Nothing is settled, it's just a bunch of suggestions I'm making to bootstrap further debates, now that it seems the majority agrees to implement a single per-market oracle wrapper (see #49)