Active path for MIPS Processors #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for review? I'm asking since there seems to be commented out code, lack of formatting (I haven't set up a CI gate here, but it should comply with https://github.com/mortbopet/VSRTL/blob/master/.clang-format), and duplicate variables. |
|
This vsrtl code is needed for the Ripes code to working. The duplicate
variables and commented out code is not needed. I thought I removed the
commented out code.
Me and my colleagues prepare the code on Ripes so we will upload it soon
…On Fri, 9 Jun 2023, 10:51 Morten Borup Petersen, ***@***.***> wrote:
Is this ready for review? I'm asking since there seems to be commented out
code, lack of formatting (I haven't set up a CI gate here, but it should
comply with https://github.com/mortbopet/VSRTL/blob/master/.clang-format),
and duplicate variables.
—
Reply to this email directly, view it on GitHub
<#57 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ7TEBNOFN2Z6FAPTKSVKJLXKLIYXANCNFSM6AAAAAAY67MP7M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello. Do I need to delete these PRs and uploade them again? I mean compatible with qt6 and without comments |
SteliosKaragiorgis
force-pushed
the
master
branch
from
a1391e4
to
ceaab72
Compare
SteliosKaragiorgis
force-pushed
the
master
branch
from
eb37da2
to
8fd0bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.