Add option to run non-interactively

[schemar]

In order to automatically restart the faucet it must be possible to run it non-interactively.

Also fixed linter setup.

References #16.

[schemar]

References #16

[gulshanvasnani]

Nice work 👍
Below comments needs to be addressed :

1. non-interactive option won't work if different chain's account have different passwords.
2. Update readme describing non-interactive option.
3. Found linting issues.

[schemar]

Thanks!

1. non-interactive option won't if different chain's account have different passwords.

True, what do you propose in order to fix this? I can't think of a proper solution for this. 🧐 Except maybe adding the password to the configuration, but I am not sure that the passwords should be stored in a file 🤔
@deepesh-kn @pgev @benjaminbollen ideas how to craft this well?

2. Update readme describing non-interactive option.

Will update the README 👍

3. Found linting issues.

Linting will be handled in a separate issue #18.

[gulshanvasnani]

Sorry that I missed below point to mention :
Change the DEFAULT_PORT to a number greater or equal to 1024. Any number below 1024 results in error with message as Error: listen EACCES: permission denied 0.0.0.0:80

[gulshanvasnani]

Thanks!

1. non-interactive option won't if different chain's account have different passwords.

True, what do you propose in order to fix this? I can't think of a proper solution for this. 🧐 Except maybe adding the password to the configuration, but I am not sure that the passwords should be stored in a file 🤔
@deepesh-kn @pgev @benjaminbollen ideas how to craft this well?

One solution could be to accept array of passwords. The sequence of password specified should be same as the chain sequence.
Example:

 ./faucet -p 8084 3 1406 -n test3 test1406

In the above example, password for chain 3 and 1406 is test3 and test1406 respectively.

[schemar]

Thanks!

1. non-interactive option won't if different chain's account have different passwords.

True, what do you propose in order to fix this? I can't think of a proper solution for this. 🧐 Except maybe adding the password to the configuration, but I am not sure that the passwords should be stored in a file 🤔
@deepesh-kn @pgev @benjaminbollen ideas how to craft this well?

One solution could be to accept array of passwords. The sequence of password specified should be same as the chain sequence.
Example:

 ./faucet -p 8084 3 1406 -n test3 test1406

In the above example, password for chain 3 and 1406 is test3 and test1406 respectively.

You cannot have a variable number of arguments to an option, as the command line interpreter wouldn't know where the option ends and the program arguments start. You would need to do it with something like a comma separated string ./faucet --non-interactive "test3,test1406" 3 1406. That could work, but it has a very strong assumption on the order of execution, which I think the executable should not have any knowledge about.

Sorry that I missed below point to mention :
Change the DEFAULT_PORT to a number greater or equal to 1024. Any number below 1024 results in error with message as Error: listen EACCES: permission denied 0.0.0.0:80

It heavily depends on the environment where you run the faucet. Port 80 is the standard port for HTTP servers: https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers#Well-known_ports

[pgev]

Thanks!

1. non-interactive option won't if different chain's account have different passwords.

True, what do you propose in order to fix this? I can't think of a proper solution for this. 🧐 Except maybe adding the password to the configuration, but I am not sure that the passwords should be stored in a file 🤔
@deepesh-kn @pgev @benjaminbollen ideas how to craft this well?

Passing multiple passwords on a command line is cumbersome and I would propose to avoid it. I would rather propose to pass a password file, which would specify password per each address@chainid in command line. First line in password file corresponds to the first address@chainid in cli, and so on.

One solution could be to accept array of passwords. The sequence of password specified should be same as the chain sequence.
Example:

 ./faucet -p 8084 3 1406 -n test3 test1406

In the above example, password for chain 3 and 1406 is test3 and test1406 respectively.

You cannot have a variable number of arguments to an option, as the command line interpreter wouldn't know where the option ends and the program arguments start. You would need to do it with something like a comma separated string ./faucet --non-interactive "test3,test1406" 3 1406. That could work, but it has a very strong assumption on the order of execution, which I think the executable should not have any knowledge about.

Sorry that I missed below point to mention :
Change the DEFAULT_PORT to a number greater or equal to 1024. Any number below 1024 results in error with message as Error: listen EACCES: permission denied 0.0.0.0:80

It heavily depends on the environment where you run the faucet. Port 80 is the standard port for HTTP servers: https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers#Well-known_ports

[schemar]

Passwords are now read from a file. Also fixed some linting.
@pgev / @gulshanvasnani please have a look.

[gulshanvasnani]

Good work.
LGTM 👍

[schemar]

@pgev do you want to have a look or can we merge?