Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device train microbatch size pt 2 #1776

Merged
merged 5 commits into from
Dec 3, 2022

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

  • renames train_device_microbatch_size to device_train_microbatch_size based on feedback
  • updates notebook example of AGA
  • updates tutorial on AGA

What issue(s) does this change relate to?

CO-1466

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

docs/source/notes/auto_grad_accum.rst Outdated Show resolved Hide resolved
docs/source/notes/auto_grad_accum.rst Outdated Show resolved Hide resolved
docs/source/notes/auto_grad_accum.rst Outdated Show resolved Hide resolved
docs/source/notes/auto_grad_accum.rst Outdated Show resolved Hide resolved
docs/source/notes/auto_grad_accum.rst Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit 2781def into mosaicml:dev Dec 3, 2022
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/aga-notebook branch December 3, 2022 01:07
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 13, 2022
* update docs, rename var

* update comments

* fix links

* fix underline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants